Skip to content

i18n(ja): keep literal TiDB error message text in English - #23618

Open
yahonda wants to merge 2 commits into
i18n-ja-release-8.5from
fix-error-message-literal-strings
Open

i18n(ja): keep literal TiDB error message text in English#23618
yahonda wants to merge 2 commits into
i18n-ja-release-8.5from
fix-error-message-literal-strings

Conversation

@yahonda

@yahonda yahonda commented Aug 27, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Found while reviewing #23616 (and the follow-up information_schema check): a literal, log-matchable TiDB error message string had been translated into Japanese, breaking its usefulness for grepping actual log/error output. Fixed 3 sites, all verified against the English source:

  • faq/sql-faq.md: heading 「情報スキーマが古くなっています」というエラーの原因は何ですか?「Information schema is out of date」というエラーの原因は何ですか? (the body of the same section already correctly kept the literal string in English — the heading was self-contradicting it)
  • troubleshoot-tidb-cluster.md: 情報スキーマが古くなっています:InformationSchema is out of date: (matches the literal log message text)
  • tidb-cloud/sql-concepts.md: 「情報スキーマが変更されました」というエラー「Information schema is changed」というエラー

Note: the general translation "情報スキーマ" for the Information Schema feature/concept name elsewhere in the corpus (e.g. information-schema/information-schema.md's own H1) is correct and unaffected by this PR — only these 3 literal quoted-error-message instances were wrong.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Updated FAQ and troubleshooting headings to use consistent English terminology.
    • Replaced localized error text with the actual English messages users may see.
    • Preserved existing anchors, explanations, and troubleshooting guidance.

Fixes 3 sites where a literal, log-matchable error message string
(e.g. "Information schema is out of date") had been translated into
Japanese, breaking its usefulness for searching actual log/error output.
@ti-chi-bot ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Aug 27, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilin90 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 27, 2026
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The documentation updates three Information Schema references from Japanese text to English error-message terminology. The FAQ anchor and troubleshooting explanation remain unchanged.

Changes

Information Schema terminology

Layer / File(s) Summary
Update Information Schema error messages
faq/sql-faq.md, tidb-cloud/sql-concepts.md, troubleshoot-tidb-cluster.md
The FAQ heading and troubleshooting label now use Information schema is out of date. The SQL concepts documentation uses the actual message Information schema is changed. Existing anchors and explanations remain unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: 🔵 Low · up to 6e52a

The PR corrects three Japanese documentation references, but one troubleshooting label still differs from the literal TiDB error text and may hinder log searches. This is a bounded documentation issue that is mergeable with explicit owner follow-up.

Suggested reviewers: qiancai

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: preserving literal TiDB error messages in English for the Japanese documentation.
Description check ✅ Passed The description explains the change, lists all three affected files, identifies the applicable Japanese TiDB 8.5 branch, provides a related reference, and records AI involvement. Required sections are…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

Full details: Description check

Explanation

The description explains the change, lists all three affected files, identifies the applicable Japanese TiDB 8.5 branch, provides a related reference, and records AI involvement. Required sections are substantially complete.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-error-message-literal-strings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 33a322d6-8ca5-4bba-990c-35bb2bf94238

📥 Commits

Reviewing files that changed from the base of the PR and between d41688a and 6e52a61.

📒 Files selected for processing (3)
  • faq/sql-faq.md
  • tidb-cloud/sql-concepts.md
  • troubleshoot-tidb-cluster.md

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Comment thread troubleshoot-tidb-cluster.md Outdated
…and schema)

Per CodeRabbit review: the correct error text is "Information schema is
out of date" (matching 7 other occurrences across the corpus), not
"InformationSchema" (one word) as originally applied.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant