Add private endpoint management tips. - #23612
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe documentation now describes private endpoint scope, sharing, persistence after resource deletion, deletion restrictions, and automatic cleanup after 30 days of inactivity. ChangesPrivate endpoint lifecycle
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This PR adds localized management tips to two private endpoint guides without changing product behavior, so no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 45879bcf-66a1-40e2-905a-f8fd82d77cec
📒 Files selected for processing (2)
tidb-cloud/premium/set-up-sink-private-endpoint-premium.mdtidb-cloud/set-up-sink-private-endpoint.md
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.
|
@ideascf: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
||
| > **Note:** | ||
| > | ||
| > A private endpoint is a tenant-level resource and is not tied to a specific instance. Private endpoints created within the same tenant and in the same region can be shared by multiple instances connecting to the same downstream service, so you do not need to create a separate endpoint for each instance. Deleting an instance does not delete its private endpoints. You can manually delete a private endpoint when it is no longer needed, or wait for it to be automatically cleaned up after 30 days of inactivity. A private endpoint cannot be deleted if it is still in use by any instance. |
There was a problem hiding this comment.
| > A private endpoint is a tenant-level resource and is not tied to a specific instance. Private endpoints created within the same tenant and in the same region can be shared by multiple instances connecting to the same downstream service, so you do not need to create a separate endpoint for each instance. Deleting an instance does not delete its private endpoints. You can manually delete a private endpoint when it is no longer needed, or wait for it to be automatically cleaned up after 30 days of inactivity. A private endpoint cannot be deleted if it is still in use by any instance. | |
| > A private endpoint is an organization-level resource and is not tied to a specific {{{ .premium }}} instance. Private endpoints created within the same organization and in the same region can be shared by multiple instances connecting to the same downstream service, so you do not need to create a separate endpoint for each instance. Deleting a {{{ .premium }}} instance does not delete its private endpoints. You can manually delete a private endpoint when it is no longer needed, or wait for it to be automatically cleaned up after 30 days of inactivity. A private endpoint cannot be deleted if it is still in use by any instance. |
| > **Note:** | ||
| > | ||
| > A private endpoint is a tenant-level resource and is not tied to a specific instance. Private endpoints created within the same tenant and in the same region can be shared by multiple instances connecting to the same downstream service, so you do not need to create a separate endpoint for each instance. Deleting an instance does not delete its private endpoints. You can manually delete a private endpoint when it is no longer needed, or wait for it to be automatically cleaned up after 30 days of inactivity. A private endpoint cannot be deleted if it is still in use by any instance. | ||
|
|
There was a problem hiding this comment.
What does "wait for it to be automatically cleaned up after 30 days of inactivity” mean? Will a private endpoint be deleted if it is unused for 30 days even if the corresponding instance is still available?
First-time contributors' checklist
What is changed, added or deleted? (Required)
The private endpoint guide missed some tips for how we manage the private endpoints, add those tips for dedicated and premium.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit