PILOT-65: fix pilotctl --json version to emit JSON#363
Closed
hank-pilot wants to merge 1 commit into
Closed
Conversation
The global --json flag was being ignored by the version command,
which unconditionally wrote fmt.Println(version) to stdout.
Fix: use output(version) which respects the jsonOutput flag and
emits the standard {"status":"ok","data":"v1.12.4"} envelope
when --json is set.
Found by PILOT-65 Phase 1 functional test runner (44/45 passing).
Collaborator
Author
|
Closing — the command is intentionally exempt from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
pilotctl --json versionwas returning plaintext (v1.12.4) instead of JSON.Root cause: The
versiondispatch case calledfmt.Println(version)unconditionally, ignoring the--jsonflag.Fix: Replace
fmt.Println(version)withoutput(version)which respects thejsonOutputflag and emits the standard{"status":"ok","data":"v1.12.4"}envelope when--jsonis set.Before:
After:
Found by PILOT-65 Phase 1 functional test runner (44/45 tests passing; this was the sole failure).