[trees][wip] MiddleTruncation from css grid hack to text-overflow: ellipsis#939
[trees][wip] MiddleTruncation from css grid hack to text-overflow: ellipsis#939SlexAxton wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35f90f39ca
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
|
|
||
| [data-truncate-content='visible'] { | ||
| text-overflow: ellipsis; |
There was a problem hiding this comment.
When MiddleTruncate is used with priority="equal", both segment containers get priority 1 and are allowed to shrink together. Because this new rule gives every truncation segment a native text-overflow: ellipsis, constrained equal-priority splits can now paint an ellipsis on both halves at the seam (for example abc… …xyz); the previous implementation explicitly suppressed one marker in this mode so only one middle marker appeared.
Useful? React with 👍 / 👎.
1 participant
close but not yet ready for prime time