Updated GH token flow#930
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7323495920
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import { cn } from '@/lib/cn'; | ||
|
|
||
| export const CREATE_TOKEN_URL = | ||
| 'https://github.com/settings/personal-access-tokens/new?name=DiffsHub&description=Read+private+diffs+and+post+review+comments+from+DiffsHub&expires_in=90&contents=read&pull_requests=write&issues=write'; |
There was a problem hiding this comment.
Avoid templating write-scoped PATs for read-only flows
For users who follow this link only to view private diffs, the generated fine-grained PAT now requests pull_requests=write and issues=write, while the inspected DiffsHub GitHub integration only performs read/GET requests (/api/diff fetches pull, compare, and diagnostics, and github-diff-file exposes only GET). This leaves users storing a localStorage token with unnecessary PR/issue write authority, increasing the blast radius if the browser token is compromised; keep these permissions at read until a posting flow actually uses them.
Useful? React with 👍 / 👎.
No description provided.