[diffs] Refactor Edit Persistance - #1092
Draft
amadeus wants to merge 8 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Found 26 test failures on Blacksmith runners: Failures
...and 16 more test failures. View all on Blacksmith
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light.png)
ije
reviewed
Aug 24, 2026
| * in memory so a later editor using the same kind and key can resume them. | ||
| */ | ||
| constructor( | ||
| documentKind: EditorDocumentKind, |
Collaborator
There was a problem hiding this comment.
maybe introduce DiffsEditor and FileEditor instead of argument?
Member
Author
There was a problem hiding this comment.
That's a possibility, but felt like that was yet another large refactor that would happen on top of an already large refactor heh, so figured this was simpler and matched what we do in other places with like InteractionManager
This cleans up a ton of internal code around session persistance. Also fixed a bug with collapsed state resetting undo state when it shouldn't
Still some rough edged to be worked out in the next couple phases.
This is a lot, and I had to fight my way through a bunch of different things, but I think we also fixed a bunch of bad bugs alogn the way. We've now hooked up documentKey retention.
This turned out to be a bit bigger than I originally thought because there was a bunch of bullshit that wasn't properly accounted for and the AI did definitely do some slop. Anyways, I think we've landed somewhere that's really good, the default persistance works really nicely now with the homepage stuff, and doesn't require any hacky bullshit
Also hook it up in the agent ui
About to be rewritten
Getting the plumbing in place for the new API
amadeus
force-pushed
the
amadeus/remove-editor-persistance
branch
from
August 25, 2026 00:14
7d30437 to
a92d427
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP