[diffs] Edit Completion Handling - #1089
Draft
amadeus wants to merge 50 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
amadeus
force-pushed
the
amadeus/edit-complete-handler
branch
from
August 20, 2026 21:07
69497ae to
6413057
Compare
* upgrade to bun 1.4.0 * dedupe
otherwise you can get into bad scenarios where you combine 1 file with other files that don't have cache keys and you're fucked cause the cache keys will match but be incorrect
Realized as we were working through this, that annotations need to also be sesssion own. This had a huge benefit of actually simplifying a lot of the APIs around managing how annotations are moved during an edit session, and should tie in nicely at the end when we manage the commit/revert API for `onEditComplete`.
There was a nasty bug with server rendered code where adjusting url params would re-load the page and force new content to flush whatever edits you were making...
Also ensure it understands the various types of teardowns
annotations that needed resolving
Simplified accept/reject into returned string literals. This is much simpler and more ergo, and helps prevent users cloning and doing dumb shit
amadeus
force-pushed
the
amadeus/edit-complete-handler
branch
from
August 21, 2026 02:13
9d0f860 to
28e4a60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds edit completion handlers to components so a dev can accept or reject the edits easily.
Also reworks how line annotations are managed during an edit session, making them far less brittle.