Fix Lighthouse accessibility issues in docs components - #1082
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 206670851d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
necolas
approved these changes
Aug 20, 2026
Rebuild the diff style/playground toggles as a single label + checkbox ToggleSwitch (one adequately sized tap target instead of a button stacked with a Radix switch), mark the remaining decorative switches aria-hidden, name previously unlabeled buttons/switches/textareas, make CopyCodeButton a real button, and convert the footer h4 column headings to styled paragraphs to fix heading order. Excludes the separate <main> landmark work and the SEO metadata changes.
Add a <main> landmark in the shared DocsLayout and ThemeLayout so the /docs and /theme routes expose a single primary content region for assistive tech. Other routes still lack a <main> and are handled separately.
Wrap the primary content of the Diffs home, Trees home, and Edit pages in a <main> landmark. Also make the Header mobile toggle aria-label reflect what it opens: the site navigation menu when the Header owns the popover, or the docs table of contents otherwise.
mdo
force-pushed
the
docs-a11y-lighthouse-fixes
branch
from
August 25, 2026 04:39
4afe225 to
8a818d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes several Lighthouse accessibility audit failures in the docs app (diffs + trees), from two chats. Scoped to component-level a11y only; the
<main>landmark work and the separate SEO metadata pass are intentionally excluded (see below).label+ native checkboxToggleSwitch(apps/docs/components/ui/toggle-switch.tsx) instead of a<button>visually stacked with a Radix switch (which rendered a second, undersized<button>). This collapses each pill to one adequately sized tap target, fixing thetarget-sizefailure. Checked pills use theoutlinevariant, unchecked usesecondarywith a transparent border so toggling never shifts layout.DemoGitStatus,DemoDragDropClient)aria-hidden+tabIndex={-1}so the adjacent button is the sole named control.aria-labelon the playground/AgentUi textareas and various buttons/switches.CopyCodeButtonfrom a clickable<div>to a real<button>with anaria-label.<h4>column headings to styled<p>elements to fix theheading-orderviolation (they wereh4s with no precedingh2/h3).