Skip to content

chore(skills): /feature Phase 0.0 — fetch issue body + aged-scope re-validation gate#3929

Merged
PierreBrisorgueil merged 2 commits into
masterfrom
chore/feature-intake-body-gate
Jul 2, 2026
Merged

chore(skills): /feature Phase 0.0 — fetch issue body + aged-scope re-validation gate#3929
PierreBrisorgueil merged 2 commits into
masterfrom
chore/feature-intake-body-gate

Conversation

@PierreBrisorgueil

@PierreBrisorgueil PierreBrisorgueil commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

What

The Phase 0.0 claim step fetched number,title,state,assignees,comments — never the issue body, so the scope written in the description was silently ignored by the executor. It also implemented aged issues as-written even when the referenced code had moved.

  • fetch body + createdAt in the Phase 0.0 gh issue view call; the body is the primary scope source
  • new §4 aged-scope gate: old issue (createdAt > ~7 days) or references that no longer match the codebase → re-validate scope against current code, present drift before implementing; un-claim on abort
  • §Proceed renumbered to 5

Doc-only change to .claude/skills/feature/SKILL.md.

Closes #3928

Summary by CodeRabbit

  • Documentation
    • Added a new re-validation gate for older or potentially drifted issue details, prompting confirmation of scope before implementing.
    • Expanded guidance to review issue content and timing before starting, including clearer prompts when the request no longer matches the current codebase.
    • Improved issue lookup context to generate more reliable summaries and decisions.
  • Bug Fixes
    • Avoids leaving partial state (such as assignment or work-in-progress markers) when the re-validation step is canceled.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 971a3282-90b9-444c-8c02-1d4351ef25bf

📥 Commits

Reviewing files that changed from the base of the PR and between 8a90aa3 and 096c0e9.

📒 Files selected for processing (1)
  • .claude/skills/feature/SKILL.md

Walkthrough

Modified the feature skill to fetch body and createdAt from GitHub issue state, and added a pre-Phase 0 aged-scope gate that re-validates older or drifted issues and cleans up claim state on abort.

Changes

Aged-scope re-validation

Layer / File(s) Summary
Issue field fetch and aged-scope gate
.claude/skills/feature/SKILL.md
Expands gh issue view to include body and createdAt, and adds a pre-Phase 0 gate that re-validates scope drift for aged or mismatched issues, removing the @me assignee and deleting the WIP — comment if the user aborts.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related issues

Possibly related PRs

Suggested labels: Feat

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change but omits most required template sections, including Summary, Scope, Validation, and Guardrails check. Add the missing template sections with module impact, risk level, validation steps, guardrails, and any optional alignment details.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: fetching issue body data and adding an aged-scope re-validation gate.
Linked Issues check ✅ Passed The PR adds issue body/createdAt to the claim step and implements the aged-scope re-validation gate requested by #3928.
Out of Scope Changes check ✅ Passed The extra rollback-on-abort and renumbering changes are part of the requested gate flow, so no unrelated scope is evident.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/feature-intake-body-gate

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.claude/skills/feature/SKILL.md:
- Around line 56-64: The aged-scope flow in SKILL.md should not leave a stale
claim marker behind when the user aborts at the re-validation gate. Update the
gate logic around the claim/WIP handling so that the claim step happens only
after the aged-scope check succeeds, or otherwise ensure the existing WIP
comment from the claim flow is also removed when calling the unassign step. Use
the nearby “Aged-scope gate (re-validate before implementing)” section and the
“Proceed to Phase 0” transition to locate the change.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 32aebda4-2bab-48f3-9e0f-23d3d8459c4d

📥 Commits

Reviewing files that changed from the base of the PR and between 7916876 and 8a90aa3.

📒 Files selected for processing (1)
  • .claude/skills/feature/SKILL.md

Comment thread .claude/skills/feature/SKILL.md
…validation gate

The claim step read number,title,state,assignees,comments but never the
issue body, so the scope written in the description was silently ignored.
Add body to the fetch and a re-validation gate: an old issue (or one whose
references no longer match the codebase) gets its scope re-checked against
current code, with drift presented to the user before implementation.

Closes #3928
Removing only the assignee left the WIP — comment behind, which step 2
treats as a resumable claim on the next run.
@PierreBrisorgueil PierreBrisorgueil force-pushed the chore/feature-intake-body-gate branch from d401734 to 096c0e9 Compare July 2, 2026 14:46
@PierreBrisorgueil PierreBrisorgueil merged commit 9558e22 into master Jul 2, 2026
3 checks passed
@PierreBrisorgueil PierreBrisorgueil deleted the chore/feature-intake-body-gate branch July 2, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🔧 /feature Phase 0.0: fetch the issue body + aged-scope re-validation

1 participant