Skip to content

Fix: read orders from the list that isn't stale after a partial fill #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piekstra merged 1 commit into from
Jul 29, 2026
Merged

Fix: read orders from the list that isn't stale after a partial fill #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/commands/quote.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,17 +254,23 @@ fn fetch_state(client: &crate::client::LoftyClient, property_id: &str) -> Result
.cloned()
})
.ok_or_else(|| CliError::NotFound(format!("no active LP program for {property_id}")))?;
// Deliberately the `all=true` list filtered client-side, NOT the cheaper
// `?propertyId=` query: after a PARTIAL fill the property-scoped list keeps
// reporting the order's ORIGINAL quantity, while `all=true` and the
// single-order GET both report what actually remains (raw-verified 2026-07-29,
// same orderId: 3 vs 2 vs 2). Sizing or covering a quote off the stale number
// works from a position that no longer exists.
let mine: Vec<Value> = client
.get(
"/public/v1/orders",
&[("propertyId", property_id.to_string())],
)?
.get("/public/v1/orders", &[("all", "true".to_string())])?
.get("orders")
.and_then(Value::as_array)
.cloned()
.unwrap_or_default()
.into_iter()
.filter(|o| o.get("status").and_then(Value::as_str) == Some("active"))
.filter(|o| {
o.get("status").and_then(Value::as_str) == Some("active")
&& o.get("propertyId").and_then(Value::as_str) == Some(property_id)
})
.collect();
let book = client.get(
&format!("/public/v1/properties/{property_id}/orderbook"),
Expand Down
Loading