Skip to content

Misleading/old documentation in http://php.net/v8jsexception and V8Js::__construct #289

Description

@TysonAndre
  • V8JsException is not guaranteed to have the method getJsFileName() defined, if it's a V8JsTimeLimitException
  • The 2 subtypes of exceptions aren't documented in php.net (V8JsScriptException and V8JsTimeLimitException)

Also, https://secure.php.net/manual/en/v8js.construct.php is misleading, (for $parameters), passing names of globals stopped working for me in php 7.0 (I assume you moved away from that design?)

EDIT(June 7, 2017): __construct is also out of date, compare with what is currently in the readme


    /**
     * Initializes and starts V8 engine and returns new V8Js object with it's own V8 context.
     * Snapshots are supported by V8 4.3.7 and higher.
     * @param string $object_name
     * @param array $variables
     * @param array $extensions
     * @param bool $report_uncaught_exceptions
     * @param string $snapshot_blob
     */
    public function __construct($object_name = "PHP", array $variables = [], array $extensions = [], $report_uncaught_exceptions = TRUE, $snapshot_blob = NULL)
    {}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions