Add processQueueUserSelectQuery hook to let plugins order the send queue - #1126
Open
Steph501 wants to merge 1 commit into
Open
Add processQueueUserSelectQuery hook to let plugins order the send queue#1126Steph501 wants to merge 1 commit into
Steph501 wants to merge 1 commit into
Conversation
The query that selects the subscribers of a campaign has no ORDER BY, so subscribers are processed in whatever order the database returns them, which in practice is import order. A plugin has no way to change this: every existing hook runs after the selection. This adds one hook, called with the query just before it is run, in both places where the subscriber list is selected. Without a plugin the query is returned untouched, so behaviour is unchanged.
Contributor
|
I haven't tried it, but looking at the code looks fine. It does of course allow the plugin to change the entire query, which is slightly worrying, but at this stage, I don't think we need to be bothered about that. |
Contributor
|
Yes, the CLA stuff isn't working. I can't figure out why, but as you indicate you went through the process I think it's fine. Also, can you change the target branch to release-3.7.0 so that it can be added to that release. |
Member
|
I just noticed I was logged in with the wrong account ;-) |
michield
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
processQueueUserSelectQueryhook, called with the subscriber select query just before it is run, so that a plugin can change the order in which subscribers are sent to. It is called at both selection points, including theMESSAGEQUEUE_PREPAREbranch. With no plugin the query is returned unchanged, so behaviour is unchanged for existing installations.Related Issue
#1125
Contributor License Agreement
The GitHub authorisation works (confirmed by email), but the return lands on a blank page, on every attempt. I will sign as soon as it is fixed.