Skip to content

Disable JIT when pthread protection is unavailable#22853

Draft
realFlowControl wants to merge 1 commit into
php:masterfrom
realFlowControl:florian/fix-apple-silicon-zts-jit-runtime-check
Draft

Disable JIT when pthread protection is unavailable#22853
realFlowControl wants to merge 1 commit into
php:masterfrom
realFlowControl:florian/fix-apple-silicon-zts-jit-runtime-check

Conversation

@realFlowControl

Copy link
Copy Markdown
Contributor

Follow up to #22712 (comment)

This moves the runtime capability check into zend_jit_check_support(). When the pthread_jit_write_protect_np() is unavailable at runtime, OPcache now logs an ACCEL_LOG_WARNING, disables JIT, and continues using the interpreter. This matches the existing unsupported-JIT behavior.

@iluuu1994 iluuu1994 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Florian! Looks correct to me. The PR is still marked as draft, let me know when you think it's ok to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants