Skip to content

uri: replace google.com with example.com in URI test fixtures#21807

Merged
kocsismate merged 1 commit intophp:masterfrom
jordikroon:uri-hostname
Apr 19, 2026
Merged

uri: replace google.com with example.com in URI test fixtures#21807
kocsismate merged 1 commit intophp:masterfrom
jordikroon:uri-hostname

Conversation

@jordikroon
Copy link
Copy Markdown
Contributor

NIT: discouraging the use of google in tests

Copy link
Copy Markdown
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use example.com or example.net.

@jordikroon jordikroon changed the title uri: replace google.com with php.net in URI test fixtures uri: replace google.com with example.com in URI test fixtures Apr 18, 2026
@jordikroon
Copy link
Copy Markdown
Contributor Author

It has been changed to example.com @TimWolla

@LamentXU123
Copy link
Copy Markdown
Contributor

LamentXU123 commented Apr 19, 2026

@jordikroon Hi. Can you please explain the benefit you see from this change🤔 IMO we are only using google urls as parsing tests, not actually sending HTTP requests to it (so it can be any legit URLs in these case) In curl the case is quite the same that we only use the google URLs for parsing test AFAIK. So it maybe ok to use the original URL🤔

Edited: so the case in curl is not the same where we actually send request to servers so using local ones is good, but I don't think this change has obvious benefits on the uri extension.

@jordikroon
Copy link
Copy Markdown
Contributor Author

I agree there’s no functional difference here since we’re only parsing and not making requests. That said, using example.com makes it clearer that these are placeholder URLs and avoids relying on real domains (like google).

Also, someone might later reuse this example in a context where it does matter, so I think it’s better to standardize on example.com IMHO.

@LamentXU123
Copy link
Copy Markdown
Contributor

Also, someone might later reuse this example in a context where it does matter, so I think it’s better to standardize on example.com IMHO.

Thats a good point :)

@kocsismate kocsismate merged commit fad4323 into php:master Apr 19, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants