uri: replace google.com with example.com in URI test fixtures#21807
uri: replace google.com with example.com in URI test fixtures#21807kocsismate merged 1 commit intophp:masterfrom
Conversation
TimWolla
left a comment
There was a problem hiding this comment.
Please use example.com or example.net.
034e2db to
6fca280
Compare
|
It has been changed to example.com @TimWolla |
|
@jordikroon Hi. Can you please explain the benefit you see from this change🤔 IMO we are only using google urls as parsing tests, not actually sending HTTP requests to it (so it can be any legit URLs in these case) Edited: so the case in curl is not the same where we actually send request to servers so using local ones is good, but I don't think this change has obvious benefits on the uri extension. |
|
I agree there’s no functional difference here since we’re only parsing and not making requests. That said, using example.com makes it clearer that these are placeholder URLs and avoids relying on real domains (like google). Also, someone might later reuse this example in a context where it does matter, so I think it’s better to standardize on example.com IMHO. |
Thats a good point :) |
NIT: discouraging the use of google in tests