phar: cap decompression output against declared uncompressed_filesize#21806
Open
iliaal wants to merge 1 commit intophp:PHP-8.4from
Open
phar: cap decompression output against declared uncompressed_filesize#21806iliaal wants to merge 1 commit intophp:PHP-8.4from
iliaal wants to merge 1 commit intophp:PHP-8.4from
Conversation
phar_open_entry_fp() decompressed entries by streaming compressed_filesize bytes through a filter into a tmpfile, then checked output size after the full copy. A crafted phar whose compressed data expanded beyond uncompressed_filesize could write large amounts to disk before the check ran. Replace the single php_stream_copy_to_stream_ex() call with an 8 KiB chunked loop that flushes the decompression filter and checks running output size after each chunk. Abort when output exceeds uncompressed_filesize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents decompression amplification in
phar_open_entry_fp().The function decompressed entries by streaming
compressed_filesizebytes through a filter into a tmpfile, then checked the output size after the full copy. A crafted phar whose compressed data expanded beyonduncompressed_filesizecould write large amounts to disk before the check ran.Replaces the single
php_stream_copy_to_stream_ex()call with an 8 KiB chunked loop that flushes the decompression filter and checks the running output size after each chunk. Aborts when output exceedsuncompressed_filesize.