Add stub.php and generate arginfo headers#52
Conversation
|
From a quick look, this add type hinting and return type This breaks compatibility with PHP 7.x (still supported from package.xml) So this need a @generate-legacy-arginfo Missing file list change in package.xml Worth a CHANGELOG entry (+ package.xml) |
|
Please check it |
There was a problem hiding this comment.
1/ need a rebase
2/ package.xml
- don't update version
- add the changelog entry (same than in Changelog)
- remove deleted file
- add new files
3/ mailparse_arginfo.h defines ext_functions and class_mimemessage_methods which should be used (instead of mailparse_functions and mimemessage_methods)
4/ constants can also be moved in stub file
|
Hmmm... the rebase make commit list unreadable :( Can you please cleanup this PR ? |
Okay, I'll clean it up. |
Add legacy_arginfo Add legacy_arginfo constants moved to stub file constants moved to stub file
2 participants
No description provided.