CI: only run Docker and Binary builds when PR is tagged "CI: All jobs" - #2672
Merged
Merged
Conversation
…" (copied from php-src)
henderkes
requested review from
alexandre-daubois and
dunglas
and removed request for
dunglas
September 24, 2026 13:11
dunglas
reviewed
Sep 24, 2026
| types: [opened, synchronize, reopened, labeled] | ||
| branches: | ||
| - main | ||
| paths: |
Member
There was a problem hiding this comment.
It may still help save some CI time when merged on main etc?
Contributor
Author
There was a problem hiding this comment.
No, I think it should always run then, so you're (we're) warned before tagging a release that there's an issue with docker images or binary builds.
dunglas
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(copied from php-src).
we get too many red squiggles just because docker login didn't work, or any of the 40 downloaded libraries failed, or spc has a problem, or, or, or. Aside from wasting build time, it really makes the red check a lot less useful.