imagick: fix broken methodsynopsis xpointers in exception classes#5700
Open
lacatoire wants to merge 1 commit into
Open
imagick: fix broken methodsynopsis xpointers in exception classes#5700lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
This was referenced Jul 23, 2026
alfsb
approved these changes
Jul 23, 2026
alfsb
left a comment
alfsb
left a comment
Member
There was a problem hiding this comment.
Plan to merge this after the bigger one, that also removes xi:fallback.
These five exception classes have no own methods, so the &Methods; include pointed at a non-existent refentry. The &InheritedMethods; include used the class's own name as methodsynopsis role instead of 'Exception', so both selected an empty node set, which older libxml (2.9, CI) reports as a failed XInclude while newer libxml (2.15) silently swallows. Drop the own-methods include and mirror the working jsonexception pattern: inherit the Exception constructor and methods with role='Exception'.
lacatoire
force-pushed
the
fix/imagick-exception-xpointers
branch
from
July 24, 2026 08:21
12b89d9 to
8a01eb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The five Imagick exception classes had broken
<xi:include>xpointers maskedby empty
<xi:fallback/>: an own-methods include pointing at a non-existentrefentry, and an inherited-methods include using the class name asmethodsynopsisrole instead ofException. Both selected an empty node set,so the pages rendered with their inherited methods missing.
Fixed by mirroring the working
jsonexception.xmlpattern.Related: