Skip to content

ci test: add sniffer for docbook (Do not merge!)#5510

Open
jordikroon wants to merge 14 commits into
php:masterfrom
jordikroon:test/docbook-cs-integration
Open

ci test: add sniffer for docbook (Do not merge!)#5510
jordikroon wants to merge 14 commits into
php:masterfrom
jordikroon:test/docbook-cs-integration

Conversation

@jordikroon
Copy link
Copy Markdown
Member

@jordikroon jordikroon commented Apr 23, 2026

Please ignore this. Testing to see how everything runs in CI.

Since this is an external tool (authored by me), it's probably better to discuss the use over the mailing list.

-> https://news-web.php.net/php.doc/969388652

@jordikroon jordikroon force-pushed the test/docbook-cs-integration branch from de26349 to 9f13728 Compare June 1, 2026 19:59
Use BASE_SHA environment variable to handle both pull requests and push events consistently. Replace github.base_ref references with the computed BASE_SHA, which correctly uses pull_request.base.sha for PRs and github.event.before for push events. Simplify merge-base check logic and improve comments for clarity. This fixes style checking on push events where github.base_ref is unavailable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant