Skip to content

Remove filename conventions for do-not-translate in revcheck#319

Merged
alfsb merged 2 commits into
php:masterfrom
alfsb:dnt2
Jul 20, 2026
Merged

Remove filename conventions for do-not-translate in revcheck#319
alfsb merged 2 commits into
php:masterfrom
alfsb:dnt2

Conversation

@alfsb

@alfsb alfsb commented Jul 9, 2026

Copy link
Copy Markdown
Member

This is the final part of removing filename conventions for do-not-translate files in revcheck lib.

No big changes here, but this may make third_party_ext_documentation a little less surprising, and easier to debug. Depends on doc-en 5662. Plan to merge it by next friday, if output of revchecks of all languages show no differences.

Comments and reviews wellcome.

Comment thread scripts/translation/lib/RevcheckIgnore.php
Comment thread scripts/translation/lib/RevcheckIgnore.php Outdated
@alfsb
alfsb merged commit 9391318 into php:master Jul 20, 2026
12 checks passed
@alfsb
alfsb deleted the dnt2 branch July 20, 2026 20:56
@alfsb

alfsb commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

Post tested. Detected non-expected differences on revcheck output.

Some "do not translate" files that exist on translation are marked as outdated, because revcheck cannot express the concept of files "do not translate, only in doc-en". TODOed a change in revcheck lib and script to create a new section.

@alfsb alfsb mentioned this pull request Jul 20, 2026
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants