Add Symfony 8 support by benr77 · Pull Request #64 · php-task/TaskBundle

benr77 · 2026-08-27T12:10:39Z

Widen Symfony version constraints in composer.json to allow ^8.0.

Symfony 8 removes XmlFileLoader support for DI service definitions. Convert all Resources/config/*.xml DI service files (and the test app's services.xml) to PHP ContainerConfigurator format, and switch TaskExtension and TestKernel from XmlFileLoader to PhpFileLoader.

Bundle::build() gained a void return type in Symfony 8; add it to TaskBundle::build().

Doctrine ORM 3.4+ requires either PHP 8.4 native lazy objects or the legacy VarExporter-based lazy ghost proxies, the latter of which was removed from Symfony 8's ProxyHelper. Enable native lazy objects in the test app's doctrine config when running on PHP 8.4+, since Symfony 8 requires PHP 8.2+ and native lazy objects are the only supported option once VarExporter's generateLazyGhost() is gone on PHP 8.4.

Fix a PHP 8.4 deprecation in DebugTasksCommand where round() could receive null when a task execution has no duration yet.

Widen Symfony version constraints in composer.json to allow ^8.0 across http-kernel, dependency-injection, expression-language, config, console, process, framework-bundle, finder, yaml and var-exporter. Symfony 8 removes XmlFileLoader support for DI service definitions. Convert all Resources/config/*.xml DI service files (and the test app's services.xml) to PHP ContainerConfigurator format, and switch TaskExtension and TestKernel from XmlFileLoader to PhpFileLoader. Doctrine ORM mapping XML files are untouched, as those use a separate XML driver unaffected by this removal. Bundle::build() gained a void return type in Symfony 8; add it to TaskBundle::build(). Doctrine ORM 3.4+ requires either PHP 8.4 native lazy objects or the legacy VarExporter-based lazy ghost proxies, the latter of which was removed from Symfony 8's ProxyHelper. Enable native lazy objects in the test app's doctrine config when running on PHP 8.4+, since Symfony 8 requires PHP 8.2+ and native lazy objects are the only supported option once VarExporter's generateLazyGhost() is gone on PHP 8.4. Fix a PHP 8.4 deprecation in DebugTasksCommand where round() could receive null when a task execution has no duration yet.

benr77 · 2026-08-27T12:12:15Z

I have submitted this PR plus one on the php-task/php-task repo to prepare the ground for Symfony 8 support on sulu/SuluAutomationBundle#96

The doctrine.orm.enable_native_lazy_objects config option was only added in doctrine/doctrine-bundle 2.15, which requires PHP >= 8.1. On the PHP 8.0 test job, Composer resolves an older doctrine-bundle that doesn't recognise this key, so the test app's Doctrine schema creation step failed with: Unrecognized option "enable_native_lazy_objects" under "doctrine.orm.entity_managers.default". Move the option into a separate config file that TestKernel only loads when the installed doctrine-bundle version actually supports it, detected via Composer\InstalledVersions. This keeps native lazy objects enabled on PHP 8.4+ with modern doctrine-bundle, without breaking older doctrine-bundle installs resolved on PHP 8.0/8.1.

alexander-schranz · 2026-08-27T12:32:17Z

+        "symfony/framework-bundle": "^5.4 || ^6.0 || ^7.0 || ^8.0",
+        "symfony/finder": "^5.4 || ^6.0 || ^7.0 || ^8.0",
+        "symfony/yaml": "^5.4 || ^6.0 || ^7.0 || ^8.0",
        "doctrine/doctrine-bundle": "^1.5 || ^2.0",


For Symfony 8 support Doctrine Bundle 3.0 is I think also a requirement.

wachterjohannes

LGTM except the thing with the doctrine bundle

wachterjohannes · 2026-08-27T12:55:50Z

+        "symfony/framework-bundle": "^5.4 || ^6.0 || ^7.0 || ^8.0",
+        "symfony/finder": "^5.4 || ^6.0 || ^7.0 || ^8.0",
+        "symfony/yaml": "^5.4 || ^6.0 || ^7.0 || ^8.0",
        "doctrine/doctrine-bundle": "^1.5 || ^2.0",


alexander-schranz · 2026-08-27T13:50:43Z

@benr77 I updated the composer.json but seems like some return types need be also updated to make it compatible to Symfony 8. Do you want to tackle that?

Symfony 8 hardens several DependencyInjection interfaces with strict return types. Add matching return types to TaskExtension and HandlerCompilerPass so their declarations stay compatible: - TaskExtension::getConfiguration(): ?ConfigurationInterface - TaskExtension::load(): void - TaskExtension::prepend(): void - HandlerCompilerPass::process(): void Without these, PHP raises a fatal 'Declaration ... must be compatible with ...' error on Symfony 8.

Symfony\Component\Console\Application::add() was removed in Symfony 8.0 in favour of addCommand(); use addCommand() when available and fall back to add() on older Symfony versions. doctrine/doctrine-bundle 3.0 removed the 'doctrine.orm.auto_generate_proxy_classes' config option, so only load it for older doctrine-bundle versions, the same way enable_native_lazy_objects is already guarded for newer ones. The test app registered DoctrineBundle unconditionally, even for the 'array' storage config which never loads any 'doctrine' extension config. On doctrine-bundle 3.x this made the container compilation fail with 'You have requested a non-existent parameter doctrine.dbal.connection_factory.types', since RegisterDbalTypePass now runs unconditionally for any registered DoctrineBundle. Only register DoctrineBundle when the 'doctrine' storage is selected.

Copilot

Pull request overview

This PR updates TaskBundle to be installable and runnable with Symfony 8 by widening Composer constraints and migrating DI service configuration away from XML (which Symfony 8 no longer supports for service definitions), while also updating the test application to handle DoctrineBundle/ORM behavior changes on newer PHP/Symfony versions.

Changes:

Widen Symfony component constraints in composer.json to allow ^8.0 (and expand Doctrine dev constraints accordingly).
Convert bundle + test-app DI service definitions from Resources/config/*.xml to PHP ContainerConfigurator files and switch loaders from XmlFileLoader to PhpFileLoader.
Update the test app kernel/config to conditionally load DoctrineBundle and handle DoctrineBundle/ORM options across versions; fix a PHP 8.4 deprecation in DebugTasksCommand.

Reviewed changes

Copilot reviewed 35 out of 35 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/Functional/BaseCommandTestCase.php	Adds compatibility logic for registering commands across console application variants.
tests/app/TestKernel.php	Switches to `PhpFileLoader`, conditionally registers DoctrineBundle, and conditionally loads doctrine config based on installed bundle capabilities.
tests/app/config/services.xml	Removes XML-based test-app service definitions (replaced by PHP).
tests/app/config/services.php	Adds PHP `ContainerConfigurator`-based test-app service definitions.
tests/app/config/config.doctrine.yml	Removes `auto_generate_proxy_classes` from the base doctrine config (now version-gated).
tests/app/config/config.doctrine_native_lazy_objects.yml	Adds optional doctrine config enabling native lazy objects via a parameter.
tests/app/config/config.doctrine_auto_generate_proxy_classes.yml	Adds optional doctrine config for `auto_generate_proxy_classes` when supported.
src/TaskBundle.php	Adds `: void` return type to `build()` for Symfony 8 compatibility.
src/Resources/config/task_event_listener.xml	Removes XML parameters config (replaced by PHP).
src/Resources/config/task_event_listener.php	Adds PHP parameters config for task event constants.
src/Resources/config/storage/doctrine.xml	Removes XML doctrine storage service definitions (replaced by PHP).
src/Resources/config/storage/doctrine.php	Adds PHP doctrine storage service definitions.
src/Resources/config/storage/array.xml	Removes XML array storage service definitions (replaced by PHP).
src/Resources/config/storage/array.php	Adds PHP array storage service definitions.
src/Resources/config/scheduler.xml	Removes XML scheduler service definitions (replaced by PHP).
src/Resources/config/scheduler.php	Adds PHP scheduler service definitions.
src/Resources/config/locking/storages.xml	Removes XML locking storage definitions (replaced by PHP).
src/Resources/config/locking/storages.php	Adds PHP locking storage definitions (tagged storage services).
src/Resources/config/locking/services.xml	Removes XML locking services definitions (replaced by PHP).
src/Resources/config/locking/services.php	Adds PHP locking services definitions.
src/Resources/config/locking/null.xml	Removes XML null-lock definitions (replaced by PHP).
src/Resources/config/locking/null.php	Adds PHP null-lock definitions.
src/Resources/config/listener.xml	Removes XML listener service definitions (replaced by PHP).
src/Resources/config/listener.php	Adds PHP listener service definitions.
src/Resources/config/executor/separate.xml	Removes XML separate executor definitions (replaced by PHP).
src/Resources/config/executor/separate.php	Adds PHP separate executor definitions.
src/Resources/config/executor/inside.xml	Removes XML inside executor definitions (replaced by PHP).
src/Resources/config/executor/inside.php	Adds PHP inside executor definitions.
src/Resources/config/command.xml	Removes XML console command definitions (replaced by PHP).
src/Resources/config/command.php	Adds PHP console command definitions.
src/DependencyInjection/TaskExtension.php	Switches to `PhpFileLoader` and updates extension method signatures/config loading to use PHP DI resources.
src/DependencyInjection/HandlerCompilerPass.php	Adds `: void` return type to `process()` (and keeps handler-tag collection logic).
src/Command/DebugTasksCommand.php	Avoids passing `null` to `round()` by defaulting duration to `0.0`.
composer.json	Expands Symfony and Doctrine constraints to include Symfony 8 + DoctrineBundle 3 / fixtures 2 where applicable.
.github/workflows/test-application.yaml	Extends CI matrix (adds PHP 8.5 entries; adjusts ignore-platform flags usage).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

alexander-schranz · 2026-08-28T05:38:56Z

@benr77 Thank you, we tagged 4.1.0: https://github.com/php-task/TaskBundle/releases/tag/4.1.0

benr77 force-pushed the feat/symfony-8-support branch from aef0ad1 to 3d34280 Compare August 27, 2026 12:20

alexander-schranz requested a review from wachterjohannes August 27, 2026 12:31

alexander-schranz reviewed Aug 27, 2026

View reviewed changes

alexander-schranz approved these changes Aug 27, 2026

View reviewed changes

wachterjohannes requested changes Aug 27, 2026

View reviewed changes

Update composer doctrine dependencies

ac8f808

wachterjohannes approved these changes Aug 27, 2026

View reviewed changes

Update PHP 8.5

c766b6c

benr77 added 2 commits August 27, 2026 14:04

alexander-schranz approved these changes Aug 27, 2026

View reviewed changes

alexander-schranz requested a lite review from Copilot August 27, 2026 14:33

alexander-schranz added the enhancement label Aug 27, 2026

Copilot started reviewing on behalf of alexander-schranz August 27, 2026 14:33 View session

Copilot AI reviewed Aug 27, 2026

View reviewed changes

Comment thread src/TaskBundle.php

Comment thread src/DependencyInjection/HandlerCompilerPass.php

Amoifr mentioned this pull request Aug 27, 2026

Symfony 8 Support sulu/sulu#8216

Open

78 tasks

alexander-schranz merged commit 992f9e0 into php-task:master Aug 28, 2026
13 checks passed

benr77 deleted the feat/symfony-8-support branch August 28, 2026 07:22

Navigation Menu

Uh oh!

Add Symfony 8 support - #64

Add Symfony 8 support#64
alexander-schranz merged 6 commits into
php-task:masterfrom
benr77:feat/symfony-8-support

benr77 commented Aug 27, 2026

Uh oh!

benr77 commented Aug 27, 2026

Uh oh!

alexander-schranz Aug 27, 2026

Uh oh!

wachterjohannes Aug 27, 2026

Uh oh!

wachterjohannes left a comment

Uh oh!

wachterjohannes Aug 27, 2026

Uh oh!

alexander-schranz commented Aug 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexander-schranz commented Aug 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

benr77 commented Aug 27, 2026

Uh oh!

benr77 commented Aug 27, 2026

Uh oh!

alexander-schranz Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

wachterjohannes Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

wachterjohannes left a comment

Choose a reason for hiding this comment

Uh oh!

wachterjohannes Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

alexander-schranz commented Aug 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexander-schranz commented Aug 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants