Cover the empty-figure early return in plain text - #272
Merged
Conversation
renderFigure() returns an empty string when nothing in the figure renders, skipping the blank-line terminator every other block emits. No source spells that shape, so the branch went uncovered; the AST does, and FigureGroupExtension reaches it whenever a figure div holds no renderable content.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #272 +/- ##
=========================================
Coverage 92.41% 92.42%
Complexity 3682 3682
=========================================
Files 109 109
Lines 10440 10440
=========================================
+ Hits 9648 9649 +1
+ Misses 792 791 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverage follow-up to #271, which Codecov flagged with one uncovered line.
PlainTextRenderer::renderFigure()returns an empty string when nothing inside the figure renders, so an empty figure contributes no text at all - not even the blank line every other block terminates with. No djot source spells that shape, which is why the branch stayed uncovered, but the AST does, andFigureGroupExtension(#270) reaches it whenever a figure div holds no renderable content.The test builds the node directly rather than parsing, because parsing cannot produce it.