Conversation
_beautifyOnSave only checked the global on/off preference before running the beautify command, not whether any provider was actually registered for the saved file's language. Saving a file type with no beautify provider (eg. plain text) unconditionally attempted to beautify, which failed and surfaced an error popover on every save. Guard with the same _getEnabledProviders() check already used to enable/disable the manual Beautify command, so unsupported file types silently no-op on save instead. Fixes #3103 Also adds a safety-net afterEach in BeautificationManager-test.js that resets "beautify on save" if a test leaves it toggled on, and a new integration suite (Beautify-integ-test.js) that exercises the real save -> documentSaved -> beautify-on-save flow end to end, covering both the no-provider no-op case and the happy path.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_beautifyOnSave only checked the global on/off preference before running the beautify command, not whether any provider was actually registered for the saved file's language. Saving a file type with no beautify provider (eg. plain text) unconditionally attempted to beautify, which failed and surfaced an error popover on every save.
Guard with the same _getEnabledProviders() check already used to enable/disable the manual Beautify command, so unsupported file types silently no-op on save instead.
Fixes #3103
Also adds a safety-net afterEach in BeautificationManager-test.js that resets "beautify on save" if a test leaves it toggled on, and a new integration suite (Beautify-integ-test.js) that exercises the real save -> documentSaved -> beautify-on-save flow end to end, covering both the no-provider no-op case and the happy path.