test(prepared_statements): avoid corrupting PS after setting number of PS to 0 - #1340
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
levkk
approved these changes
Aug 11, 2026
levkk
reviewed
Aug 11, 2026
levkk
reviewed
Aug 11, 2026
meskill
force-pushed
the
meskill-2026-08-08-fix-prepared_statements---wsp
branch
from
August 11, 2026 18:21
bd156b4 to
5f1a2a3
Compare
Base automatically changed from
meskill-2026-08-10-fix-prepared_statements---vxw
to
main
August 11, 2026 18:51
meskill
force-pushed
the
meskill-2026-08-08-fix-prepared_statements---wsp
branch
from
August 11, 2026 18:51
5f1a2a3 to
e48b1aa
Compare
… PS to 0 - prevent counter reset to avoid newly created prepared statement treated like old one without shape check - do not clear global hashmap for keys since that could lead to attempt to reuse statement name wiped from global cache
meskill
force-pushed
the
meskill-2026-08-08-fix-prepared_statements---wsp
branch
from
August 11, 2026 18:55
e48b1aa to
6806997
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it was fixed already by #1331 but anyway at-least here is integration-like test for this with the helpers to reuse later