Skip to content

Fix for #10187 -PG 19 extension changes breaks pgAdmin extension UI#10188

Open
robe2 wants to merge 1 commit into
pgadmin-org:masterfrom
robe2:fix_extension_pg19
Open

Fix for #10187 -PG 19 extension changes breaks pgAdmin extension UI#10188
robe2 wants to merge 1 commit into
pgadmin-org:masterfrom
robe2:fix_extension_pg19

Conversation

@robe2

@robe2 robe2 commented Jul 24, 2026

Copy link
Copy Markdown

Fixes #10187
Extension UI gives error with PG 19
column reference "comment" is ambiguous LINE 5: e.comment

Issue caused because in pg19 :

SELECT * FROM pg_catalog.pg_available_extensions();

now outputs an additional column location
after default_version and comment is now 4th column.

Removed the aliasing cause the aliasing was redundant since pg_available_extensions() already names them as expected using out parameters.

Summary by CodeRabbit

  • Bug Fixes
    • Improved extension metadata queries for better compatibility with current PostgreSQL function output.
    • Extension properties and search results continue to display extension information consistently.

Extension UI gives error with PG 19
column reference "comment" is ambiguous LINE 5: e.comment

Issue caused because in pg19 :

SELECT * FROM pg_catalog.pg_available_extensions();

now outputs an additional column `location`
after default_version and comment is now 4th column
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Extension metadata queries now join pg_available_extensions() without explicit column lists in the browser extension properties query and PostgreSQL/PPAS object search queries, preserving extension-name matching and comment selection.

Changes

Extension query compatibility

Layer / File(s) Summary
Use native extension columns
web/pgadmin/browser/server_groups/servers/databases/extensions/templates/extensions/sql/properties.sql, web/pgadmin/tools/search_objects/templates/search_objects/sql/pg/default/search.sql, web/pgadmin/tools/search_objects/templates/search_objects/sql/ppas/default/search.sql
The extension metadata joins use the native output columns from pg_available_extensions() instead of an explicit (name, default_version, comment) list.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The SQL changes directly address issue #10187 by removing the redundant pg_available_extensions column aliasing that caused the PG19 ambiguity.
Out of Scope Changes check ✅ Passed The edits are limited to the extension query templates needed for the reported PG19 bug and add no obvious unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is clearly related to the PR’s main fix for PostgreSQL 19 extension UI breakage.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@robe2 robe2 changed the title Fix for #10187 Fix for #10187 -PG 19 extension changes breaks pgAdmin extension UI Jul 24, 2026
@robe2

robe2 commented Jul 24, 2026

Copy link
Copy Markdown
Author

FWIW I tested this against PG14, PG18, and PG19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

create extension UI gives error with PG 19

1 participant