Fix index/constraint column not shown when its name requires quoting (#6481)

[dpage]

Summary

Fixes #6481.

When an index (or exclusion constraint) column name requires quoting — e.g. it contains a double quote or other special characters — the column was not shown in the Properties panel, and editing reported it as empty.

Root cause: the is_exp (expression) flag is computed as pg_get_indexdef(...) = a.attname. pg_get_indexdef() returns the SQL-quoted identifier (e.g. "col""x") while a.attname is the raw name (col"x). For any name needing quoting these never match, so a plain column was misclassified as an expression and dropped.

Fix: compare against pg_catalog.quote_ident(a.attname), which yields the same quoted form as pg_get_indexdef() for both normal and special names. Real expression indexes (where attname is NULL) still evaluate as expressions.

Changes

• indexes/sql/11_plus/column_details.sql, indexes/sql/default/column_details.sql, exclusion_constraint/sql/default/get_constraint_cols.sql
• Release note (9.16)

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

• Documentation

  • Added release notes for pgAdmin 4 version 9.16, including supported database versions and bundled utilities.

• Bug Fixes

  • Fixed an issue where quoted index and exclusion constraint column names were not displaying correctly in the Properties panel.

[coderabbitai]

Warning

Review limit reached

@dpage, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 7 minutes and 26 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2d211fe2-3ab1-4233-9167-735ef477e018

📥 Commits

Reviewing files that changed from the base of the PR and between 9e3ce68 and 464cc15.

📒 Files selected for processing (4)

• docs/en_US/release_notes_9_16.rst
• web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/exclusion_constraint/sql/default/get_constraint_cols.sql
• web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/indexes/sql/11_plus/column_details.sql
• web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/indexes/sql/default/column_details.sql

Walkthrough

This PR fixes issue #6481 by updating SQL templates for index and exclusion constraint column retrieval to compare index definitions against quoted identifier forms instead of raw attribute names, enabling proper display of columns with special characters in the Properties panel.

Changes

Quoted Identifier Fix for Index and Constraint Columns

Layer / File(s)	Summary
Release notes for version 9.16 docs/en_US/release_notes.rst, docs/en_US/release_notes_9_16.rst	Added version 9.16 release notes documenting fix for issue #6481 (quoted index/exclusion constraint column names appearing correctly in Properties panel) and listing supported PostgreSQL versions 13–18 with bundled utilities at version 18.2.
SQL template fixes for quoted identifier comparison web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/exclusion_constraint/sql/default/get_constraint_cols.sql, web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/indexes/sql/11_plus/column_details.sql, web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/indexes/sql/default/column_details.sql	Updated the is_exp CASE expression in each template to compare pg_get_indexdef(...) against the quoted identifier form (pg_catalog.quote_ident(a.attname)) rather than raw column names, ensuring columns with special characters are matched correctly.

---

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately describes the main fix: addressing the issue where index/constraint columns with quoted names were not displayed in the Properties panel.
Linked Issues check	✅ Passed	The PR directly addresses issue #6481 by fixing the SQL logic that was misclassifying quoted indexed columns as expressions, causing them to be omitted from the Properties panel.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the quoted identifier handling in index and exclusion constraint column queries, with corresponding release notes documentation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[asheshv]

The SQL fix (comparing against quote_ident(a.attname) instead of a.attname) is correct — is_exp will now classify properly. But the Python side that displays the column name is still broken for the exact category the PR claims to fix.

web/pgadmin/browser/server_groups/servers/databases/schemas/tables/indexes/utils.py:123 uses attdef.strip('"'). str.strip('"') strips outer quotes but doesn't unescape doubled inner quotes. For a column named col"x, pg_get_indexdef returns "col""x"; .strip('"') yields col""x, not col"x. So the properties panel still displays the wrong name for any identifier containing a literal ".

Pull this into a tiny helper:

def unquote_ident(s):
    if s.startswith('"') and s.endswith('"'):
        return s[1:-1].replace('""', '"')
    return s

Tests gap: no scenarios for quoted-identifier column names (uppercase, spaces, reserved words, embedded "). The regression that caused #6481 wouldn't have been caught by existing tests, and this PR doesn't add coverage for it.