Cherry-pick: Fix incorrect subscription name in Phase 9 of ZODAN add_node#428
Cherry-pick: Fix incorrect subscription name in Phase 9 of ZODAN add_node#428mason-sharp wants to merge 2 commits intov5_STABLEfrom
Conversation
create_sub_on_new_node_to_src_node generated sub_{subscriber}_{provider}
instead of the expected sub_{provider}_{subscriber} convention, causing
remove-node to fail when looking up subscriptions by their expected name.
Introduce spock.gen_sub_name(provider_node, subscriber_node) helper and
replace all inline 'sub_' || concatenations to prevent future mismatches.
(cherry picked from commit eb844b9)
Up to standards ✅🟢 Issues
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mason-sharp
changed the title
1 participant
create_sub_on_new_node_to_src_node generated sub_{subscriber}{provider} instead of the expected sub{provider}_{subscriber} convention, causing remove-node to fail when looking up subscriptions by their expected name.
Introduce spock.gen_sub_name(provider_node, subscriber_node) helper and replace all inline 'sub_' || concatenations to prevent future mismatches.
(cherry picked from commit eb844b9)