Capture the PowerShell Gallery package as a build artifact

[nohwnd]

Problem

The publish pipeline artifact only contained the nuget.org/Chocolatey nupkg (tmp/nuget/Pester.<version>.nupkg), never the PowerShell Gallery one.

Publish-Module packs the gallery module into a random system temp folder and discards it after the push:

C:\Users\VssAdministrator\AppData\Local\Temp\821736127\Pester\Pester.6.0.0-rc1.nupkg

That path is outside tmp/, so the artifact upload (which captures tmp/) never sees it. When the gallery push fails — as it did with 403 (The specified API key is invalid, has expired, or does not have permission...) — the agent is torn down and the signed package is gone. Nothing overwrites it; it's simply never written under tmp/.

Fix

Before the gallery push, pack the module into tmp/PSGallery-package/ via a temporary local PSRepository. This produces the exact PowerShell Gallery–format .nupkg (same packing logic as Publish-Module) and saves it where the pipeline artifact already looks, so it's captured even when the gallery push fails.

The capture is wrapped in try/catch/finally so its own failure never blocks the real publish, and the temporary repository is always unregistered.

After this, the artifact contains:

pester-packages/
  nuget/             Pester.<version>.nupkg   (nuget.org + Chocolatey)
  PSGallery-package/ Pester.<version>.nupkg   (PowerShell Gallery)  ← new
  PSGallery/Pester/  (unpacked module folder)

Note

The 403 means the PsGalleryApiKey variable in the AzDO signing group is invalid/expired and needs rotating. This PR doesn't fix that — it ensures the signed gallery package is always downloadable so it can be published manually in the meantime.

Pipeline stays trigger: none (manual), so this applies on the next publish run.

[fflaten]

AFAIK you could simplify this with Compress-PSResource and Publish-PSResource -NupkgPath ..., though haven't tested it personally

[nohwnd]

I am just stupid and forgot that powersehll modules are published from folder, not as nupkg, that is why I am hunting it.

[nohwnd]

@fflaten thanks, this made me realize the whole gallery capture is pointless. The gallery is published from the module folder, not a nupkg, so there is nothing to capture there. The packaged nupkg only goes to nuget and choco. Reworked it in #2910, it drops the gallery capture and puts the nuget and choco packages into their own named folders.

🤖