Do not zero DSA allocations for queries#784
Merged
Merged
Conversation
Since we allocate only exactly the length of the query and then directly copies the query into the memory requesting zeroed memory makes no sense.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #784 +/- ##
==========================================
+ Coverage 87.59% 87.75% +0.16%
==========================================
Files 3 3
Lines 1314 1315 +1
Branches 187 187
==========================================
+ Hits 1151 1154 +3
+ Misses 80 79 -1
+ Partials 83 82 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dutow
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we allocate only exactly the length of the query and then directly copies the query into the memory requesting zeroed memory makes no sense.
PG-0
Description
Links