Skip to content

SimpleTable manual modal edit/delete picks wrong element after filter/sort #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samhere06 wants to merge 2 commits into
base: release/25
Choose a base branch
from
Open

SimpleTable manual modal edit/delete picks wrong element after filter/sort #619

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
259ecea
SimpleTable manual modal edit/delete picks wrong element after filter…
samhere06 Jun 29, 2026
1c2e3b4
removed unneccessary comments
samhere06 Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 32 additions & 42 deletions ...dk-components/src/components/template/SimpleTable/SimpleTableManual/SimpleTableManual.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,16 +443,7 @@ export default function SimpleTableManual(props: PropsWithChildren<SimpleTableMa
if (order !== 0) return order;
return a[1] - b[1];
});

const newElements = new Array(stabilizedThis.length);
stabilizedThis.forEach((el, index) => {
// Use the original index recorded on the row (set in generateRowsData)
// so that filtering (which shrinks rowData but not `elements`) still maps
// each surviving row to the correct rendered cells.
const originalIndex = (el[0] as any)?.__originalIndex ?? el[1];
newElements[index] = elements[originalIndex];
});
return newElements;
return stabilizedThis.map(([el]) => el);
}

function _menuClick(event, columnId: string, columnType: string, labelValue: string) {
Expand Down Expand Up @@ -699,39 +690,38 @@ export default function SimpleTableManual(props: PropsWithChildren<SimpleTableMa
{(readOnlyMode || allowEditingInModal) &&
rowData &&
rowData.length > 0 &&
stableSort(rowData, getComparator(order, orderBy))
.slice(0)
.map((row, index) => {
return (
<TableRow key={index}>
{row?.map((item, childIndex) => {
const theColKey = displayedColumns[childIndex];
return (
<TableCell key={theColKey} className={classes.tableCell}>
{item}
</TableCell>
);
})}
{showDeleteButton && (
<TableCell key='DeleteIcon' className={classes.tableCell}>
<div>
<MoreIcon
id='table-edit-menu-icon'
className={classes.moreIcon}
onClick={event => {
editMenuClick(event, index);
}}
/>
<Menu id='table-edit-menu' anchorEl={editAnchorEl} keepMounted open={Boolean(editAnchorEl)} onClose={_menuClose}>
<MenuItem onClick={() => editRecord()}>Edit</MenuItem>
<MenuItem onClick={() => deleteRecord()}>Delete</MenuItem>
</Menu>
</div>
stableSort(rowData, getComparator(order, orderBy)).map((row: any, displayIndex) => {
const originalIndex = row.__originalIndex;
return (
<TableRow key={displayIndex}>
{(elements as any[])[originalIndex]?.map((item, childIndex) => {
const theColKey = displayedColumns[childIndex];
return (
<TableCell key={theColKey} className={classes.tableCell}>
{item}
</TableCell>
)}
</TableRow>
);
})}
);
})}
{showDeleteButton && (
<TableCell key='DeleteIcon' className={classes.tableCell}>
<div>
<MoreIcon
id='table-edit-menu-icon'
className={classes.moreIcon}
onClick={event => {
editMenuClick(event, originalIndex);
}}
/>
<Menu id='table-edit-menu' anchorEl={editAnchorEl} keepMounted open={Boolean(editAnchorEl)} onClose={_menuClose}>
<MenuItem onClick={() => editRecord()}>Edit</MenuItem>
<MenuItem onClick={() => deleteRecord()}>Delete</MenuItem>
</Menu>
</div>
</TableCell>
)}
</TableRow>
);
})}
</TableBody>
</Table>
{((readOnlyMode && (!rowData || rowData?.length === 0)) ||
Expand Down
Loading