fix: addresses slow frame emission due to time unit mismatch#2081
Merged
pedroSG94 merged 1 commit intopedroSG94:masterfrom Apr 24, 2026
Merged
Conversation
Owner
|
Hello, Merged, Thank you for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SilenceAudioSource.create() computes sleepTime in microseconds (* 1_000_000L) but passes it to kotlinx.coroutines.delay(Long), which interprets its argument as milliseconds. As a result the silent PCM frames are emitted ~1000× slower than real time. When used with RTMP ingestors that require an audio track (e.g. YouTube), the muxer holds video waiting on audio-timestamp progression, producing multi-second to multi-minute A/V lag. Changing the multiplier from 1_000_000L to 1_000L makes the cadence match the frame's PCM duration.
Reproduction
RtmpStream with SilenceAudioSource, stream to YouTube — latency grows unboundedly. With the fix, latency matches a MicrophoneSource stream.