chore: make deferred v4 parameters required - #17817
Open
DanRibbens wants to merge 1 commit into
Open
Conversation
Resolves the `@todo make required in v4.0` markers for parameters left optional in v3 for backwards-compat (PYLD-2711). - parentIsLocalized is now required on getLocalizedPaths (payload), hasLocalesTable (@payloadcms/drizzle), and the field-hook arg types - name is now required on DatabaseAdapterResult / DatabaseAdapterObj - updated call sites and removed the now-dead non-null assertions - documented the externally-exported changes in the v4 migration guide Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the
@todo make required in v4.0markers for parameters left optional in v3 for backwards-compat (PYLD-2711).Changes:
parentIsLocalizedis now required ongetLocalizedPaths(payload),hasLocalesTable(@payloadcms/drizzle), and the internal field-hook arg types.nameis now required onDatabaseAdapterResult/DatabaseAdapterObj(custom DB adapters).!assertions the optional types required.Docs: added breaking-change entries to
docs/migration-guide/v4.mdxfor the externally-exported changes (getLocalizedPaths,hasLocalesTable, custom DB adaptername).Out of scope: the
SerializedLinkNode.idmarker inrichtext-lexicalis deferred to its own ticket/PR — it requires a serialization/node-version migration, not just a type change.build:coreandlintboth pass.🤖 Generated with Claude Code