fix(ui): render named group child fields when permissions.fields is empty (Closes #17812) - #17813
Open
waterWang wants to merge 1 commit into
Open
fix(ui): render named group child fields when permissions.fields is empty (Closes #17812)#17813waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
waterWang
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
August 16, 2026 19:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a named
groupfield renders its children, it passespermissions?.fieldsto the innerRenderFieldscomponent. Ifpermissions.fieldsis empty or missing (e.g., when/api/accessreturns an empty fields object), the innerRenderFieldsreceivesundefinedor{}as permissions. This causesgetFieldPermissionsto returnread: falsefor all child fields, which are then filtered out byRenderFields— producing an empty.render-fieldscontainer.Root cause:
GroupFieldwas the only container component that didn't fall back to the parent permissions object whenpermissions.fieldswas empty. Other containers (Row,Tabs,Collapsible) passpermissionsdirectly, which includesread: trueand allows child fields to render.Changes
Permissions fallback: When
permissions.fieldsis empty or missing, fall back to the group's own permissions object instead of passingundefined. This aligns with howBlocks(BlockRow) handles the same scenario.forceRender propagation: Added
forceRenderto the props destructure and passed it to the innerRenderFields. This was already done byRowandTabsbut was missing inGroupField.How to reproduce
See the minimal reproduction in the issue. Without this fix, named
groupfields render an emptyRenderFieldscontainer — the header is visible but all child fields are missing.Closes #17812