fix: sanitize where query on findVersionByID for inherited read access - #17804
Open
DanRibbens wants to merge 1 commit into
Open
Conversation
Both collection and global findVersionByID operations combine the
version id lookup with the readVersions access result and hand the
merged where to the DB layer without running sanitizeWhereQuery.
findByID, findVersions, and countVersions all sanitize the merged
where in the same spot, so relationship-backed virtual fields resolve
to their underlying paths.
With the inherited-from-read defaults added in this branch, any
collection or global whose read access returns a query referencing a
virtual field (e.g. { authorName: { equals: X } } where authorName
is virtual: 'author.name') generates a version-scoped constraint
(version.authorName) that never gets rewritten, so the version lookup
silently fails. Mirror the sanitizeWhereQuery call from findByID /
findVersions so the two ByID operations behave the same.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
DanRibbens
changed the base branch from
main
to
codex/pyld-3081-versions-access-control
August 15, 2026 14:33
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
findVersionByIDmerge the version id lookup with thereadVersionsaccess result and hand the mergedwhereto the DB layer without runningsanitizeWhereQuery.findByID,findVersions, andcountVersionsall sanitize the mergedwherein the same spot, so relationship-backed virtual fields resolve to their underlying paths.readdefaults introduced in fix!: inherit read access for collection versions #17634, any collection or global whosereadaccess returns a query referencing a virtual field silently breaksfindVersionByID— the constraint (e.g.version.relatedLabelwhererelatedLabelisvirtual: 'related.label') never gets rewritten so the version lookup returns nothing and the caller sees Forbidden/NotFound.sanitizeWhereQuery({ fields: versionFields, payload, where })from the sibling operations in bothfindVersionByIDvariants.test/access-control/int.spec.tsthat fails on the base PR branch and passes with this fix.Test plan
pnpm run build:corepnpm run test:int access-control(50 passed, 6 skipped)🤖 Generated with Claude Code