Bump python, javascript, and C# bindings for payjoin-1.0.0 - #1831
Draft
spacebear21 wants to merge 3 commits into
Draft
Bump python, javascript, and C# bindings for payjoin-1.0.0#1831spacebear21 wants to merge 3 commits into
spacebear21 wants to merge 3 commits into
Conversation
Collaborator
Coverage Report for CI Build 32520894272Coverage remained the same at 86.718%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
spacebear21
marked this pull request as draft
August 21, 2026 19:25
Give the package its own semantic version instead of deriving it from the payjoin-ffi crate, following the per-language versioning convention: each package keeps independent semver with the wrapped payjoin core version as build metadata where the registry supports it. PyPI rejects PEP 440 local version labels (the + part), so the package publishes the bare version and records that 0.2.0 wraps payjoin-1.0.0, the first stable payjoin release, in the changelog. 0.2.0 succeeds 0.1.0.dev0, the only version previously published to PyPI, and is a minor bump because the API is not backwards compatible with it. The version now lives in pyproject.toml; setup.py no longer reads Cargo.toml, which drops the toml build and dev dependencies.
Bump the package from 0.1.1, the last version published to npm, to
0.2.0 for the release wrapping payjoin-1.0.0. The API has changed
incompatibly since 0.1.1 (session persister rework, typestate and
error overhauls, web environment support), so this is a 0.x minor
bump.
The language bindings follow a {version}+payjoin-{version} convention
where the build metadata names the wrapped payjoin core release, but
npm strips build metadata from published versions, so package.json
carries the bare version and records the full 0.2.0+payjoin-1.0.0 in
a releaseTag field for traceability. Drop the EXPERIMENTAL disclaimer
from the description now that the wrapped library is stable, matching
the dart release.
Give the package its own semantic version instead of tracking the payjoin-ffi crate version, following the per-language convention where SemVer build metadata names the wrapped payjoin core release: 0.1.0+payjoin-1.0.0 packages payjoin 1.0.0, the first stable payjoin release. Drop the -preview.N suffix since 0.x already conveys a pre-stable API. Resetting below the published 0.24.0-preview.1 avoids continuing a number that named the previously wrapped payjoin core version, which would read as confusing under the new scheme. The old versions must be unlisted on nuget.org so floating installs resolve the new line. NuGet keeps build metadata in the nuspec but strips it from the .nupkg filename and ignores it for version comparison, so the release tag stays payjoin-csharp-0.1.0, matching what the publish job derives from the packed artifact.
spacebear21
force-pushed
the
bump-bindings-payjoin-1.0.0
branch
from
August 21, 2026 19:54
3d4cb41 to
31390b0
Compare
Member
|
How comfortable are you dropping experimental tag on bound targets before payjoin-ffi 1.0? Is that ~production quality in your view then? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare the remaining binding releases wrapping payjoin-1.0.0 (dart already shipped as
0.2.2+payjoin-1.0.0), one commit per package. Thepayjoin-fficrate version is untouched; each language now keeps its own semver following the bark-ffi-bindings convention of{version}+payjoin-{version}build metadata, applied where the registry supports it:pyproject.tomlinstead of being derived from the crate version bysetup.py(which drops thetomlbuild/dev dependencies). PyPI rejects PEP 440 local version labels, so the package publishes the bare version and the wrapped payjoin core release is recorded in the changelog. 0.2.0 succeeds0.1.0.dev0, the only version previously on PyPI, as a minor bump since the API is not backwards compatible with it. Release tag:payjoin-python-0.2.0.package.jsoncarries the bare version plus areleaseTagfield recording0.2.0+payjoin-1.0.0, mirroring bark's npm workaround. Also drops the EXPERIMENTAL disclaimer, matching the dart release. Release tag:payjoin-javascript-0.2.0.0.1.0+payjoin-1.0.0: resets from 0.24.0-preview.1, whose number tracked the previously wrapped payjoin core version and would read as confusing under the new scheme; the-preview.Nsuffix is dropped since 0.x already conveys a pre-stable API. NuGet keeps the metadata in the nuspec but strips it from the.nupkgfilename and version comparisons (verified with a localdotnet pack), so the release tag ispayjoin-csharp-0.1.0, matching what the publish job derives from the artifact. Requires unlisting0.24.0-preview.1and0.0.1on nuget.org so floating installs resolve the new line.Each RELEASING.md's versioning section is updated to codify the convention for its language.
Closes the release item in #1816 once tagged and published.
Disclosure: co-authored by Claude Fable 5
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.
https://claude.ai/code/session_019BcdiyBCQQChuJ3dy7QJwm