Skip to content

docs(images): design guidelines assets#5058

Open
andrew-ronaldson wants to merge 2 commits into
patternfly:mainfrom
andrew-ronaldson:design-images
Open

docs(images): design guidelines assets#5058
andrew-ronaldson wants to merge 2 commits into
patternfly:mainfrom
andrew-ronaldson:design-images

Conversation

@andrew-ronaldson

Copy link
Copy Markdown
Contributor

@patternfly-build

patternfly-build commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Preview: https://pf-org--pr-5058-site.surge.sh

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something got a little funky with the input item. I clicked into the components and now they're all full width like the previous image (should be a quick update)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to update the link button text (if we don't care that it just says "Button" instead of "External link", we can leave it as-is)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's a small thing, but External link would be better. Button could be confusing.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of these page examples have the default icon + text nav items. I can update them to match the original images or leave them as-is if we don't think it's a big deal

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's a big deal to leave as-is. It still matches the generic nature of all the components on the page.

@bekah-stephens bekah-stephens left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments, but other than that it lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants