Skip to content

fix: npm run start with existing build artifacts#3100

Merged
bennypowers merged 3 commits intomainfrom
fix/start-with-build-artifacts
Apr 15, 2026
Merged

fix: npm run start with existing build artifacts#3100
bennypowers merged 3 commits intomainfrom
fix/start-with-build-artifacts

Conversation

@bennypowers
Copy link
Copy Markdown
Member

@bennypowers bennypowers commented Apr 15, 2026

Summary

Exclude build output files from tsconfig.esbuild.json so
npm run start doesn't fail with "Cannot write file because
it would overwrite input file" when build artifacts are present.

Closes #2712

Test plan

  • Build the project, then run npm run start

Exclude build outputs (.js, .d.ts, .js.map) from the esbuild tsconfig
so TypeScript doesn't try to overwrite them.

Closes #2712

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 15, 2026

🦋 Changeset detected

Latest commit: c6cb684

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/elements Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 15, 2026

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit f13afdd
😎 Deploy Preview https://deploy-preview-3100--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "fix: npm run start with existing build artifacts"
}

@github-actions github-actions bot added the AT passed Automated testing has passed label Apr 15, 2026
@github-actions

This comment has been minimized.

@bennypowers bennypowers enabled auto-merge (squash) April 15, 2026 13:13
@github-actions

This comment has been minimized.

@bennypowers bennypowers disabled auto-merge April 15, 2026 13:26
@bennypowers bennypowers enabled auto-merge (squash) April 15, 2026 13:26
@bennypowers bennypowers merged commit b057f87 into main Apr 15, 2026
16 checks passed
@bennypowers bennypowers deleted the fix/start-with-build-artifacts branch April 15, 2026 13:35
@github-actions
Copy link
Copy Markdown
Contributor

SSR Test Run for f13afdd: Report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm run start can fail if typescript build files are present

2 participants