Skip to content

test(tabs): add axe tree test for selected state#3098

Merged
bennypowers merged 2 commits intomainfrom
test/tabs-axe-selected
Apr 15, 2026
Merged

test(tabs): add axe tree test for selected state#3098
bennypowers merged 2 commits intomainfrom
test/tabs-axe-selected

Conversation

@bennypowers
Copy link
Copy Markdown
Member

@bennypowers bennypowers commented Apr 15, 2026

Summary

Add tests verifying the accessibility tree shows the correct
selected state on tabs, both on initial render and after
selecting a different tab.

Closes #2771

Test plan

  • npx wtr elements/pf-tabs/test/pf-tabs.spec.ts

Closes #2771

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 15, 2026

⚠️ No Changeset found

Latest commit: 66e34ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 15, 2026

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 7820d11
😎 Deploy Preview https://deploy-preview-3098--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 15, 2026

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "test(tabs): add axe tree test for selected state"
}

@github-actions github-actions bot added the AT passed Automated testing has passed label Apr 15, 2026
@github-actions

This comment has been minimized.

@bennypowers bennypowers enabled auto-merge (squash) April 15, 2026 13:13
@markcaron markcaron requested a review from adamjohnson April 15, 2026 13:51
Copy link
Copy Markdown
Collaborator

@adamjohnson adamjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic Guarantees Tab Movement

@github-actions
Copy link
Copy Markdown
Contributor

SSR Test Run for 7820d11: Report

@bennypowers bennypowers merged commit b1e3938 into main Apr 15, 2026
16 checks passed
@bennypowers bennypowers deleted the test/tabs-axe-selected branch April 15, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests: <pf-tabs> add axe tree test for selected state

2 participants