Conversation
Closes #2499 Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 61e23cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "feat(label): add link variant"
} |
This comment has been minimized.
This comment has been minimized.
v4 label links look like normal labels. Was this transparent background and no visible border coming from somewhere else? https://v4-archive.patternfly.org/v4/components/label#router-link I added a link demo |
zeroedin
left a comment
zeroedin
left a comment
There was a problem hiding this comment.
label link styles need adjusted
Match PFv4 link label behavior: on hover/focus the border thickens to 2px and changes to the primary color. Labels keep their normal background and border styling. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Heads up I improved the CSS around the border colors with link. Also improved icons css by removing duplication of selectors. @markcaron I'll remove my blocker review and allow to do the final approval. |
zeroedin
requested review from
markcaron and
zeroedin
and removed request for
zeroedin
3 participants
Summary
Added
hrefproperty topf-label. When set, the label text rendersinside an
<a>element with transparent background, no border, andunderlined text inheriting the label's color.
Closes #2499
Test plan
<pf-label href="https://example.com">Link</pf-label>renders an anchorhrefare unchanged