feat!: remove bundled entrypoint (pfe.min.js)#3089
Open
bennypowers wants to merge 3 commits intostaging/pfe5from
Open
feat!: remove bundled entrypoint (pfe.min.js)#3089bennypowers wants to merge 3 commits intostaging/pfe5from
bennypowers wants to merge 3 commits intostaging/pfe5from
Conversation
The bundled entrypoint causes custom element double-registration issues and is not the recommended way to consume the library. Closes #3087 Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: e9bc40b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "feat!: remove bundled entrypoint (pfe.min.js)"
} |
Remove the bundle() call and pfe.min.* passthrough copies from the Eleventy docs plugin, since the bundled entrypoint was removed. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
Fixes padded-blocks lint error. Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the bundled entrypoint (
pfe.min.js) from@patternfly/elements.mainfield and.export pointing topfe.min.jsfromelements/package.jsonbuild:bundlewireit config and dependency from rootpackage.jsonscripts/bundle.jsThe bundled entrypoint caused custom element double-registration issues
and is not recommended for production use. Import individual elements directly instead.
See #2960 for context.
Closes #3087
Test plan
npm run buildsucceeds withoutbuild:bundle