Skip to content

fix(tools): restore missing files in create-element package#2970

Merged
bennypowers merged 2 commits intomainfrom
fix/create-element-npmignore
Apr 15, 2026
Merged

fix(tools): restore missing files in create-element package#2970
bennypowers merged 2 commits intomainfrom
fix/create-element-npmignore

Conversation

@bennypowers
Copy link
Copy Markdown
Member

Summary

  • Adds an empty .npmignore to tools/create-element/ so that the files field in package.json controls what gets published, rather than being filtered by .gitignore
  • Newer npm versions apply .gitignore patterns even when files is set, which caused compiled output (main.js, main.d.ts, generator/) to be excluded from the 1.0.5 tarball

Closes #2967

Test plan

  • cd tools/create-element && npm pack --dry-run shows 17 files including main.js, main.d.ts, and generator/*.js
  • npm run new works downstream after publishing

…shed package

Closes #2967

Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 26, 2026

🦋 Changeset detected

Latest commit: c6a549f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/create-element Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 26, 2026

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "fix(tools): restore missing files in create-element package"
}

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 26, 2026

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit 8722cfc
😎 Deploy Preview https://deploy-preview-2970--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the AT passed Automated testing has passed label Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

SSR Test Run for 52396e5: Report

@bennypowers bennypowers enabled auto-merge (squash) April 15, 2026 13:12
@github-actions
Copy link
Copy Markdown
Contributor

SSR Test Run for 01b6413: Report

@github-actions
Copy link
Copy Markdown
Contributor

SSR Test Run for 8722cfc: Report

@bennypowers bennypowers merged commit 3935154 into main Apr 15, 2026
16 checks passed
@bennypowers bennypowers deleted the fix/create-element-npmignore branch April 15, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] missing main.js for @patternfly/create-element@1.0.5

2 participants