Add support for fp4 and fp8 E8M0 type checking - #397
Open
jtang10 wants to merge 1 commit into
Open
Conversation
Owner
|
LGTM! Looks like ruff lint is failing for some reason, but if you can fix that then I'd be happy to merge this :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds type checking for
Float4e2m1fnandFloat8e8m0fnu, which is used as the microscale of mxfp format (mxfp4 + mxfp8).Some fp4 support has been added in #353 but didn't really plumb through. This PR should have that fixed alongside the Float8e8m0fnu.
Since there's no direct
Float8support for type checking, this PR follows the same convention s.t. newly add dtypes will categorically fall underFloat.It does not look like I have to specially add new test for these dtypes but I'd be happy to if you need.