fix: pass codec options to db.command()#39
Open
msyavuz wants to merge 1 commit into
Open
Conversation
Database.command() falls back to DEFAULT_CODEC_OPTIONS when codec_options is
omitted, so options configured on the client were ignored on every read. Most
visibly, uuidRepresentation had no effect: BSON UUID fields were decoded as raw
bson.Binary instead of uuid.UUID no matter what the connection string asked for,
because reads go through db.command({'find': ...}) rather than collection.find().
Pass the database's codec options for both find and getMore, so results decode
consistently with collection.find() and across batches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Database.command()falls back toDEFAULT_CODEC_OPTIONSwhencodec_optionsis omitted, so options configured on the client were ignored on every read. Most visibly, uuidRepresentation had no effect: BSON UUID fields were decoded as raw bson.Binary instead of uuid.UUID no matter what the connection string asked for, because reads go throughdb.command({'find': ...})rather thancollection.find().Pass the database's codec options for both find and getMore, so results decode consistently with collection.find() and across batches.