fix(editor): improve duct routing and parametric controls - #862
Open
sudhir9297 wants to merge 61 commits into
Open
sudhir9297 wants to merge 61 commits into
sudhir9297 wants to merge 61 commits into
Conversation
Items (e.g. solar panels) can now be placed on sloped roof surfaces. The placement system computes euler rotation from the roof surface normal so items sit flush on the slope instead of going inside. - Add roofStrategy to placement-strategies with enter/move/click/leave - Wire roof:enter/move/click/leave events in the placement coordinator - Add calculateRoofRotation in placement-math using surface normals - Support full 3D cursor rotation for sloped surfaces - Items on roofs are parented to the level with world-space rotation Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… github.com:pascalorg/editor
# Conflicts: # packages/editor/src/components/editor/handles/handle-arrow.tsx # packages/editor/src/components/editor/index.tsx
- Keep larger duct profiles clear of wall faces - Lock runs to their starting wall surface - Remove automatic end caps with deleted runs
- Support default-expanded inspector groups and grid action buttons - Fix switch styling in the editor - Disable incompatible React Scan bootstrap loading
|
I hit an error while handling your request (Model unavailable on AI Gateway free tier: Free tier users do not have access to this model. Upgrade to paid credits at https://vercel.com/d?to=%2F%5Bteam%5D%2F%7E%2Fai%3Fmodal%3Dtop-up for unrestricted…). Please try again, rephrase, or reach out if it keeps failing. Error id: 3c5ee842-fe04-498b-b876-c397431a6467 |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c02bca2. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
Rectangular and oval duct wall clearance
Keep a run on its starting wall
Automatic endcap cleanup
Parametric inspector controls
How to test
Run the editor with
bun run dev.Draw round, rectangular, and oval duct runs against a wall.
Delete a duct or pipe with an automatic endcap.
Open a parametric inspector with multiple groups and actions.
Run
bun run checks.Focused node tests: 27 passed.
Screenshots / screen recording
Not added yet.
Checklist
bun devbun checkto verify)mainbranchNote
Medium Risk
Touches shared run-drafting logic, scene deletion cascades, and scene-load timing; behavior changes are user-visible but covered by new tests.
Overview
Improves duct/pipe drafting and inspector UX, with tighter editor load behavior and broader test coverage.
Routing & clearance: New
ductSurfaceClearanceMdrives surface clearance and wall attachments so rectangular/oval ducts use their largest cross-section dimension against walls (plus a small standoff), while floor/ceiling clearance still uses height. The shared distribution run tool locks drafting to the wall face where the run started (when not snapped to a port/body) and releases that lock when the user commits a segment that steps off the wall plane.Deletion: Duct and pipe
onDeleteCascadenow includes automatic run end caps viafindAutomaticRunEndCapIds, leaving manually placed end caps untouched.Inspector:
ParamGroupgains optionaldefaultExpanded, wired through single- and multi-selection parametric panels; action buttons use a two-column grid when parametric actions are present. Group React keys are more stable (nodeType+ label).Editor: Scene loading passes the current
sceneLoadAttemptinto the loader and only applies the graph when the attempt still matches, avoiding stale loads on rapid retries.Tests: Adds
@react-three/test-rendererand coverage for clearance math, wall locking, end-cap cascade delete, and wall-plane behavior for duct/pipe tools.Reviewed by Cursor Bugbot for commit cdf2cbc. Bugbot is set up for automated code reviews on this repo. Configure here.