Fix release package tag push - #565
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--follow-tags, which ignores the workflow’s lightweight tagsVerification
1.0.0-beta.1package tags against release commitd92c0e65Note
Low Risk
Single-line change to the release git push command; no runtime app or auth logic affected.
Overview
Fixes release tagging so per-package version tags (e.g.
@pascal-app/core@1.0.0-beta.1) actually reach the remote after the version-bump commit.The Commit version bumps & tag step in
.github/workflows/release.ymlnow runsgit push origin HEAD:main $TAGSinstead ofgit push --follow-tags. Tags are still created in a loop before the push; the change is only how they are published.--follow-tagswas not pushing these workflow-created tags reliably (including lightweight tags), so the push now namesmainand every tag in$TAGSexplicitly.Reviewed by Cursor Bugbot for commit 5d1c29d. Bugbot is set up for automated code reviews on this repo. Configure here.