🎨 Palette: Form element accessibility improvements and render optimizations#35
🎨 Palette: Form element accessibility improvements and render optimizations#35parvezk wants to merge 1 commit into
Conversation
…nDrawer renders - Refactored `SessionDrawer` to conditionally reset state during the render phase instead of `useEffect` to prevent React cascading render warnings. - Added explicit labels with `id`/`htmlFor` across inputs and textareas in `new-agent-modal.tsx`. - Assigned `role="radiogroup"` to the vendor selection and `role="radio"` with `aria-checked` to the vendor buttons to ensure correct screen reader semantics. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc60afac77
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <button | ||
| key={v} | ||
| type="button" | ||
| role="radio" | ||
| aria-checked={selected} | ||
| onClick={() => setVendor(v)} |
There was a problem hiding this comment.
When keyboard users interact with this control, role="radio" causes assistive technology to expose the tiles as a single-choice radio group, but the buttons have neither roving tabIndex nor arrow-key handling. Consequently, all four radios remain separate Tab stops and the expected arrow keys do nothing; use native radio inputs or implement the radio-group keyboard pattern.
Useful? React with 👍 / 👎.
1 participant
💡 What
This PR introduces several micro-UX and accessibility improvements focused on form usability and React performance:
role="radiogroup"androle="radio"witharia-checked).htmlForandidlinking for the Model<Select>, Repo<Input>, and Task<Textarea>fields.useEffectinsideSessionDrawerwith a conditional render-phase state update, fixing a Reactset-state-in-effectlinter error and eliminating a potential stale message flash.🎯 Why
useEffectbased on a prop change causes a double-render cycle and can briefly show stale data. Using a render-phase update immediately flushes the updated initial state.📸 Before/After
SessionDrawerpreviously triggered thereact-hooks/set-state-in-effecteslint error, which is now resolved without any functional side-effects.♿ Accessibility
<label>and their respective<input>/<SelectTrigger>/<Textarea>.aria-labelledby,role,aria-checked) added to custom non-semantic HTML form elements.PR created automatically by Jules for task 3447360759996294050 started by @parvezk