⚡ Bolt: Eliminate cascading render in SessionDrawer#28
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
💡 What: Moved the prop-driven state reset for
messageandsentinSessionDrawerout of auseEffectand into a conditional render-phase check (if (session?.id !== prevSessionId)).🎯 Why: Setting state synchronously inside a
useEffectwhen responding to prop changes triggers an extra render cycle, which causes cascading re-renders and degrades performance (and triggered an ESLint warning).📊 Impact: Eliminates an unnecessary render cycle whenever a user clicks to view a different session, resulting in a slightly snappier UI response and resolving the ESLint
react-hooks/set-state-in-effecterror.🔬 Measurement: Verified by running
cd web && pnpm lintwhich now passes without the error, and manual review of the logic. Tests and builds pass as expected.PR created automatically by Jules for task 4610172703070404862 started by @parvezk