RFC: Remove dotNsIdentifier from default account access#245
Draft
valentinfernandez1 wants to merge 1 commit into
Draft
RFC: Remove dotNsIdentifier from default account access#245valentinfernandez1 wants to merge 1 commit into
valentinfernandez1 wants to merge 1 commit into
Conversation
Drop dotNsIdentifier from the seven local account, signing, and statement-store request bodies, callers pass only derivationIndex and the host resolves the caller's own domain.
Collaborator
Author
|
Keeping as draft for now as this is a big breaking change and we need to settle on the best versioning strategy for this |
Contributor
|
The Hard NO from my side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is part 1 of a 2 part split of #243:
Today every account/signing/statement-store call takes a
ProductAccountId { dotNsIdentifier, derivationIndex }. ThedotNsIdentifieris redundant, the host already knows the calling product's domain and a dead input: pass any domain other than your own and the host just rejects it as invalid on signing related calls.So it's removed from the request bodies. Callers pass only
derivationIndex, and the host resolves the caller's own dotNS domain itself:Seven request bodies lose their ProductAccountId field in favor of a bare derivation_index: u32:
ProductAccountId itself stays defined and exported, unused for now, so Part 2 can reuse it as the explicit external-account identifier.
Includes RFC-0022 with the full rationale.