chore(dev): make the local dotli stack buildable - #419
Merged
Conversation
The vendored dotli pin predates a breaking change in @parity/truapi, where DerivationIndex stopped being a string, so hosts/dotli no longer typechecks against this checkout and make dev cannot start. Bumps it to dotli main. dev-bootstrap also forced the dev WASM profile, which builds an artifact several times dotli's service-worker precache limit; vite-plugin-pwa treats that as a build error, so the preview never starts. Drops the override so the release profile applies, and reads the limit out of dotli's own vite config in dev-link-check to fail at bootstrap with the reason rather than part-way through a dotli build.
Review found the check failing closed on inputs it was meant to tolerate. A `32 * 1024 ** 2` refactor in dotli produced an empty split segment, so the limit evaluated to zero and every build failed with a size violation that was not one. A commented-out value earlier in the file won on first-match. A missing or renamed config threw ENOENT rather than warning, which is what the comment promised it would not do. It now reads every occurrence, keeps the largest that parses as a product of positive integers, and treats anything else as a reason to skip. Moving it out of the Makefile one-liner into scripts/ is what makes that legible; all three defects came from the logic being compressed onto one line. The dev profile is also not the escape hatch the comment described: dev-bootstrap runs the check unconditionally, so TRUAPI_WASM_PROFILE=dev makes `make dev` fail rather than trading the preview away, and the old remediation line suggested a command that reproduced the failure. Both now say so.
filvecchiato
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendored dotli pin predates a breaking change in @parity/truapi, where DerivationIndex stopped being a string, so hosts/dotli no longer typechecks against this checkout and make dev cannot start. Bumps it to dotli main.
dev-bootstrap also forced the dev WASM profile, which builds an artifact several times dotli's service-worker precache limit; vite-plugin-pwa treats that as a build error, so the preview never starts. Drops the override so the release profile applies, and reads the limit out of dotli's own vite config in dev-link-check to fail at bootstrap with the reason rather than part-way through a dotli build.