feat: INF-4136 make Deployment progressDeadlineSeconds configurable - #448
Open
jmpalomares wants to merge 6 commits into
Open
feat: INF-4136 make Deployment progressDeadlineSeconds configurable#448jmpalomares wants to merge 6 commits into
jmpalomares wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds configurability for Kubernetes Deployment progressDeadlineSeconds in the shared common.deployment template so slow-starting workloads can avoid ProgressDeadlineExceeded (and resulting ArgoCD Degraded) when they legitimately need more than 10 minutes to become Ready (INF-4136).
Changes:
- Add optional
spec.progressDeadlineSecondsrendering tocommon.deployment, with global + per-workload override support. - Document
progressDeadlineSecondsinparcellab/monolith/values.yaml(defaulting to 600 for discoverability). - Bump chart versions for release publishing (
common1.3.13,monolith0.6.3).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| parcellab/common/templates/_deployment.tpl | Conditionally renders progressDeadlineSeconds from values, keeping it omitted when unset. |
| parcellab/monolith/values.yaml | Documents the new progressDeadlineSeconds value (default 600). |
| parcellab/common/Chart.yaml | Version bump to publish the library chart change. |
| parcellab/monolith/Chart.yaml | Version bump to publish the consuming chart update/documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…essDeadlineSeconds
kpplis
reviewed
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
common.deploymenthardcodes the Kubernetes defaultprogressDeadlineSeconds(600s) — there's no way for a consuming chart'svalues.yamlto raise it. This surfaced inparcelLab/dbt(prod): after fixing a liveness-probe crash-loop by adding astartupProbewith a 1500s budget for a slow-starting container, the Deployment's rollout still gets markedProgressing=False/ProgressDeadlineExceeded— and ArgoCD surfaces that asDegraded— because the pod legitimately needs longer than 10 minutes to becomeReady, independent of the probes. INF-4136Description
parcellab/common/templates/_deployment.tpl: added an optionalprogressDeadlineSecondsfield on the Deployment spec, read viadefault .Values.progressDeadlineSeconds $service.progressDeadlineSeconds(same fallback pattern already used forstrategy). When unset, the field is omitted entirely and Kubernetes applies its own 600s default — zero behavior change for existing consumers.parcellab/monolith/values.yaml: documented the new field with an explicit default of600(matching current behavior) so it's discoverable and consumers can bump it per-service or globally.parcellab/commonto1.3.13andparcellab/monolithto0.6.3so chart-releaser publishes the change.Motivation and Context
Lets slow-starting workloads (e.g. a container gated by a large
startupProbe) set a realistic rollout deadline instead of always inheriting the 600s Kubernetes default, without needing a chart change per consumer. Companion fix inparcelLab/dbtwill setprogressDeadlineSeconds: 1800in.chart/prod/values.yamlonce this is released.Testing
helm lint parcellab/commonandhelm lint parcellab/monolith: pass.helm template parcellab/monolith --set name=test: rendersprogressDeadlineSeconds: 600right afterrevisionHistoryLimit.helm template parcellab/monolith --set name=test --set progressDeadlineSeconds=1800: renders1800.helm template parcellab/monolith --set name=test --set progressDeadlineSeconds=null: field omitted entirely (falls back to the Kubernetes default), confirming no behavior change for consumers who don't set it.Breaking changes
None. Purely additive/optional field; existing consumers render identically until they opt in.
INF-4136